You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM except for the commented tests which can be pushed in a separate PR or that's completed in this PR.
Yes so like I mention in the PR, atm these functions are not really testable due to the lock time hardcoded.
So I wonder if it's better to simply remove the tests, or if there is plan to make it a value that can be control via sudo, then the test could be used...
LGTM except for the commented tests which can be pushed in a separate PR or that's completed in this PR.
Yes so like I mention in the PR, atm these functions are not really testable due to the lock time hardcoded. So I wonder if it's better to simply remove the tests, or if there is plan to make it a value that can be control via sudo, then the test could be used...
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
marc-aurele-besner
added
auto-consensus
Add staking functions and tests
This PR adds staking functionality to the SDK + tests for them
unlockFunds tests are missing as currently the 2 days lock make testing impossible