Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove observable interface #210

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Remove observable interface #210

merged 4 commits into from
Dec 23, 2024

Conversation

clostao
Copy link
Contributor

@clostao clostao commented Dec 20, 2024 •
edited
Loading

This PR substitutes the observable returning type of upload methods for a returning promise and an optional callback for tracking the upload.

Additionally, it updates the module type to node16 for assuring that asynchronous imports are not transpiled to require statements.

marc-aurele-besner
marc-aurele-besner requested changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@marc-aurele-besner marc-aurele-besner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 💪
Can we reflect these changes in the package README please?

@clostao
Copy link
Contributor Author

clostao commented Dec 23, 2024

Updated, thanks!

marc-aurele-besner
marc-aurele-besner reviewed Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@marc-aurele-besner marc-aurele-besner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just some small miss in most import in the readme, let's try to make these code snippet as copy/pastable as possible without errors 👍

packages/auto-drive/README.md Show resolved Hide resolved
marc-aurele-besner
marc-aurele-besner approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@marc-aurele-besner marc-aurele-besner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thank you very much 🙇‍♂️

@clostao clostao merged commit 3a03320 into main Dec 23, 2024
1 check passed
@clostao clostao deleted the remove-observable-upload branch December 23, 2024 13:18
@EmilFattakhov EmilFattakhov mentioned this pull request Dec 23, 2024
Merged
@clostao clostao mentioned this pull request Dec 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-aurele-besner marc-aurele-besner marc-aurele-besner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clostao @marc-aurele-besner