Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: improve observable returning type #208

Closed
wants to merge 4 commits into from

Conversation

clostao
Copy link
Contributor

@clostao clostao commented Dec 19, 2024

Having the CID as optional was a weird experience. Adding distinctly typed by the field completed makes more comprehensible.

Copy link
Collaborator

@marc-aurele-besner marc-aurele-besner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that been said, I find these two almost identical types a bit redundant

packages/auto-drive/src/api/models/uploads.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@marc-aurele-besner marc-aurele-besner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clostao
Copy link
Contributor Author

clostao commented Dec 20, 2024

Closing because is outdated

@clostao clostao closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants