Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Auto-Drive Into CJS #199

Merged
merged 8 commits into from
Dec 11, 2024
Merged

Translate Auto-Drive Into CJS #199

merged 8 commits into from
Dec 11, 2024

Conversation

clostao
Copy link
Contributor

@clostao clostao commented Dec 10, 2024 •
edited
Loading

Updates auto-drive into a cjs module by.

  • Importing functions and classes asynchronously
  • Duplicating some of the types in @autonomys/auto-dag-data
  • Removed rollup since it won't be used for multiple output (esm and cjs) build

@clostao clostao removed the request for review from marc-aurele-besner December 10, 2024 19:44
marc-aurele-besner
marc-aurele-besner approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@marc-aurele-besner marc-aurele-besner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome improvement to devEx!
Good job! 👏

@clostao clostao merged commit 6d0ccf9 into main Dec 11, 2024
1 check passed
@clostao clostao deleted the update/auto-drive-cjs branch December 11, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-aurele-besner marc-aurele-besner marc-aurele-besner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clostao @marc-aurele-besner