Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packages dedupe conflict #182

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

marc-aurele-besner
Copy link
Collaborator

@marc-aurele-besner marc-aurele-besner commented Nov 27, 2024

User description

Fix packages dedupe conflict


PR Type

enhancement, dependencies


Description

  • Updated the @polkadot/extension-dapp dependency in packages/auto-utils/package.json to version ^0.56.2.
  • Updated the @polkadot/types-codec devDependency in packages/auto-xdm/package.json to version ^14.3.1.

Changes walkthrough 📝

Relevant files
Dependencies
package.json
Update `@polkadot/extension-dapp` dependency version         

packages/auto-utils/package.json

  • Updated the version of @polkadot/extension-dapp dependency from
    ^0.54.1 to ^0.56.2.
  • +1/-1     
    package.json
    Update `@polkadot/types-codec` devDependency version         

    packages/auto-xdm/package.json

  • Updated the version of @polkadot/types-codec devDependency from
    ^11.2.1 to ^14.3.1.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Security
    Replace the insecure "fs" package with a secure version

    Replace the insecure and deprecated "fs" package version "^0.0.1-security" with a
    secure alternative or remove it if not necessary.

    packages/auto-utils/package.json [19]

    -"fs": "^0.0.1-security"
    +"fs": "<secure_version>"
    Suggestion importance[1-10]: 8

    Why: The suggestion correctly identifies a security issue with the "fs" package version and recommends updating it to a secure version, which is crucial for maintaining the security integrity of the project.

    8

    @marc-aurele-besner marc-aurele-besner merged commit bf1b053 into main Nov 27, 2024
    1 check passed
    @marc-aurele-besner marc-aurele-besner deleted the fix/packages-dedupe-resolution branch November 27, 2024 16:32
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants