Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dynamic save for both client and node #10

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Add dynamic save for both client and node #10

merged 4 commits into from
Jun 4, 2024

Conversation

marc-aurele-besner
Copy link
Collaborator

Add dynamic save for both client and node

  • Add a generic dynamic save function that both support local storage or file system (use the key as the fileName + extension in the case of a file system

abhi3700
abhi3700 previously approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@abhi3700 abhi3700 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-aurele-besner marc-aurele-besner merged commit 73ec885 into main Jun 4, 2024
3 checks passed
@marc-aurele-besner marc-aurele-besner deleted the feat/add-dynamic-save-for-both-client-and-node branch June 4, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrank-summit jfrank-summit jfrank-summit approved these changes

@abhi3700 abhi3700 abhi3700 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc-aurele-besner @abhi3700 @jfrank-summit