Make prediction async #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahho
reviewed
Dec 15, 2024
SamuelGabriel
approved these changes
Dec 16, 2024
davidotte
force-pushed
the
make-prediction-async
branch
from
e7e27c8 to
8e65d35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Try to be precise. You can additionally add comments to your PR, this might help the reviewer a lot.
This PR involves the client side for making predictions async. Please also check the corresponding Server PR. On the client side, we only need updates in client.py. We now send streaming requests and basically just loop over all messages we receive. Currently, if a duration estimation is received, I print the estimated duration and then show a progress bar that runs for this estimated duration. The question is now if we want to keep this initial print of estimated duration and if we might also want to add a message that is printed if the prediction is taking longer than expected.
If you used new dependencies: Did you add them to
requirements.txt?Yes. Should I also add version numbers?
Who did you ping on Mattermost to review your PR? Please ping that person again whenever you are ready for another review.
@noahho
Breaking changes
If you made any breaking changes, please update the version number.
Breaking changes are totally fine, we just need to make sure to keep the users informed and the server in sync.
Does this PR break the API? If so, what is the corresponding server commit?
Yes, PR mentioned above
Does this PR break the user interface? If so, why?
Please do not mark comments/conversations as resolved unless you are the assigned reviewer. This helps maintain clarity during the review process.