Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Some notes:
super()
calls that call the base class, which calls the subclass, which calls the base class and so on. In fact most of the optimizers are now a dataclass which just looks like this.BracketOptimizer
SearchSpace
as a config. This is probably only relevant for benchmarkingTODO
BracketOptimizer
, previously a mixin class calledMFBOBase
. This can mostly just re-use the things fromgp
and is essentially just aSampler
that can be used. Here's a snippet from theBracketOptimizer
. It we would essentially just use it as the sampler when the bracket saysnext_action=("new", rung)
, signalling that a new sample has to happen at a given rung.