Add checks CI and apply linters #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that the GitHub Actions is not enabled. Could you enable it and run the linter? |
herilalaina
reviewed
Oct 14, 2024
There was a problem hiding this comment.
Thank you @HideakiImamura. Github actions were actually already enabled. Could you maybe rebase from the main?
| @@ -496,7 +496,7 @@ def __init__(self, in_dim: int, out_dim: int) -> None: | |||
| in_dim - 2, out_dim | |||
| ) | |||
|
|
|||
| def forward(self, *x, **kwargs) -> torch.Tensor: | |||
| def forward(self, x: torch.Tensor, **kwargs: Any) -> torch.Tensor: | |||
There was a problem hiding this comment.
*x has to be a tuple here; otherwise, the line below will raise an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to introduce the CI for linters. The CI can greatly reduce the complexity of a codebase. By checking whether the Checks CI passes for each PR, the codebase can be kept simple in the future. Moreover, continuous type checking with tools like mypy can help discover hidden bugs.