add missing feature flag to opentelemetry_otlp for otel-push-exporter (…

…#151) * add missing feature flag to opentelemetry_otlp for otel-http-push-exporter * update changelog and rustfmt * pr review
autometrics-dev · Nov 7, 2023 · 10e9c77 · 10e9c77
1 parent fdb6234
commit 10e9c77
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Add support for tracing-opentelemetry v0.21 (#147)
 - Error messages when using `#[autometrics]` together with `#[async_trait]`
   has been improved (#149)
+- Fixed missing feature flag for `opentelemetry-otlp` when autometrics feature
+  `otel-push-exporter` is enabled
 
 ## [0.6.0](https://github.com/autometrics-dev/autometrics-rs/releases/tag/v0.5.0) - 2023-08-08
 

diff --git a/autometrics/Cargo.toml b/autometrics/Cargo.toml
@@ -40,7 +40,8 @@ otel-push-exporter = [
   "opentelemetry_sdk",
   "opentelemetry_api",
   "opentelemetry-otlp",
-  "opentelemetry-otlp/tls-roots",
+  "opentelemetry-otlp/metrics",
+  "opentelemetry-otlp/tls-roots"
 ]
 
 otel-push-exporter-http = [

diff --git a/autometrics/src/otel_push_exporter.rs b/autometrics/src/otel_push_exporter.rs
@@ -1,8 +1,7 @@
 use opentelemetry_api::metrics::MetricsError;
+use opentelemetry_otlp::OtlpMetricPipeline;
 use opentelemetry_otlp::{ExportConfig, Protocol, WithExportConfig};
-use opentelemetry_otlp::{OtlpMetricPipeline, OTEL_EXPORTER_OTLP_TIMEOUT_DEFAULT};
 use opentelemetry_sdk::metrics::MeterProvider;
-use opentelemetry_sdk::runtime;
 use std::ops::Deref;
 use std::time::Duration;