Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change pasword check in LdapValidator to falsei check so it catches … #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

change pasword check in LdapValidator to falsei check so it catches … #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/LdapValidator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ LdapValidator.prototype.validate = function (username, password, callback) {
if(!up) return callback();

// AD will bind and delay an error till later if no password is given
if(password === '') return callback();
if(!password) return callback();

var client = this._options.binder || ldap.createClient({
url: this._options.url,
Expand Down