Merge pull request #106 from aurora-is-near/fix-rbac-member-titles-de…

…terministic fix: ensure rbac member entity titles are more deterministic
aurora-is-near · Jun 7, 2024 · a029d9e · a029d9e
2 parents e74be12 + 21b964b
commit a029d9e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/wicked-shirts-collect.md b/.changeset/wicked-shirts-collect.md
@@ -0,0 +1,5 @@
+---
+'@aurora-is-near/backstage-plugin-blockchainradar-backend': patch
+---
+
+fix: ensure rbac member entity titles are more deterministic
diff --git a/plugins/blockchainradar-backend/src/entities/ContractDeployment.ts b/plugins/blockchainradar-backend/src/entities/ContractDeployment.ts
@@ -42,7 +42,10 @@ export class ContractDeployment extends BlockchainAddress {
 
     parts.push(this.humanFriendlyAddress());
 
-    if (!this.adapter.isHumanReadable) {
+    // TODO: abstract conditional into BlockchainAddress
+    // NOTE: `member` role check is done to avoid undeterministic titles from uncertain parent
+    // This is caused by addresses that are members of multiple rbac role groups
+    if (!this.adapter.isHumanReadable && this.role !== 'member') {
       parts.push(this.parent.metadata.name);
     }