fix: filter out not writable "undefined" property from globals

this property has been introduced in jsdom 16 taken from d9cfd72 of https://github.com/raiseandfall/aurelia-pal-nodejs
aurelia · Feb 22, 2024 · 69227d3 · 69227d3
1 parent d1ecfff
commit 69227d3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -66,7 +66,7 @@ function initialize() {
 exports.initialize = initialize;
 function createBrowserGlobals() {
     Object.getOwnPropertyNames(aurelia_pal_1.PLATFORM.global)
-        .filter(prop => typeof global[prop] === 'undefined')
+        .filter(prop => typeof global[prop] === 'undefined' && prop !== 'undefined')
         .forEach(prop => global[prop] = aurelia_pal_1.PLATFORM.global[prop]);
 }
 function globalize() {

diff --git a/src/index.ts b/src/index.ts
@@ -75,7 +75,7 @@ export function initialize(): void {
 function createBrowserGlobals() {
   Object.getOwnPropertyNames(PLATFORM.global)
     // avoid conflict with nodejs globals
-    .filter(prop => typeof global[prop] === 'undefined')
+    .filter(prop => typeof global[prop] === 'undefined' && prop !== 'undefined')
     .forEach(prop => global[prop] = PLATFORM.global[prop]);
 }