Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self-contained PassageNavigation #607

Merged
merged 19 commits into from
Dec 18, 2024
Merged

self-contained PassageNavigation #607

merged 19 commits into from
Dec 18, 2024

Conversation

jakecoble
Copy link
Collaborator

No description provided.

@jakecoble jakecoble requested a review from alangumer as a code owner December 8, 2024 20:47
@vercel Vercel
Copy link

vercel bot commented Dec 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
audioverse-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 8:03pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2024 •
edited
Loading

Localization Summary

language unchanged added removed untranslated
br 874 0 0 81
de 874 0 0 413
en 874 0 0 0
es 874 0 0 404
fr 874 0 0 420
ja 874 0 0 384
ru 874 0 0 394
zh 874 0 0 383

View full summary

@jakecoble jakecoble requested review from narthur and removed request for narthur and alangumer December 8, 2024 20:47
narthur
narthur approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@narthur narthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

Lighthouse Results

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

Accessibility Issues

CodeCount
WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail2200
WCAG2AA.Principle2.Guideline2_4.2_4_1.H64.1264
WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.Button.Name3
 View full summary

@jakecoble jakecoble merged commit 0f69c39 into bible-ui Dec 18, 2024
11 of 12 checks passed
@jakecoble jakecoble deleted the chapter-detail branch December 18, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narthur narthur narthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakecoble @narthur