Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-1356: Add hasIncompletePlaybackSession to Continue Listening query #583

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

jakecoble
Copy link
Collaborator

@jakecoble jakecoble commented Oct 8, 2024

@jakecoble jakecoble requested a review from alangumer as a code owner October 8, 2024 17:53
Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
audioverse-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 3:01pm

Copy link

github-actions bot commented Oct 8, 2024

Localization Summary

language unchanged added removed untranslated
br 875 0 0 79
de 875 0 0 412
en 875 0 0 0
es 875 0 0 403
fr 875 0 0 420
ja 875 0 0 383
ru 875 0 0 393
zh 875 0 0 382

View full summary

@jakecoble jakecoble force-pushed the continue-listening-fix branch from 78cd01f to 927f8f9 Compare October 8, 2024 17:54
Copy link

github-actions bot commented Oct 8, 2024

📦 Next.js Bundle Analysis for audioverse-next

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (225 KB)
/[language]/discover 9.1 KB 251.41 KB 111.74% (🟡 +0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

github-actions bot commented Oct 8, 2024

Accessibility Issues

CodeNewFixedRetainedIgnoredTotal
WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail00022102210
WCAG2AA.Principle2.Guideline2_4.2_4_1.H64.1000143143
View full summary

@narthur narthur changed the title Add hasIncompletePlaybackSession to Continue Listening query AV-1356: Add hasIncompletePlaybackSession to Continue Listening query Oct 9, 2024
@jakecoble
Copy link
Collaborator Author

Accessibility failure WCAG2AA.Principle2.Guideline2_4.2_4_1.H64.1 was not introduced by this PR.

I created a test branch off master, then I opened a test PR here: #585 The test PR, which introduces only a comment, also fails the accessibility check because of WCAG2AA.Principle2.Guideline2_4.2_4_1.H64.1.

@narthur narthur merged commit 3ff27f7 into master Oct 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants