Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed FEATURED COLLECTION from Browse page #483

Merged
merged 3 commits into from
Oct 12, 2023
Merged

removed FEATURED COLLECTION from Browse page #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
418a776
removed FEATURED COLLECTION from Browse page
okeino Oct 9, 2023
70bc722
moved Series up between Topics and Audiobooks
okeino Oct 10, 2023
f865518
commiting series change
okeino Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions public/compiled-lang/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1341,12 +1341,6 @@
"value": "Conferences"
}
],
"discoverCollections_featuredCollectionHeading": [
{
"type": 0,
"value": "Featured Collection"
}
],
"discoverCollections_storySeasonsHeading": [
{
"type": 0,
Expand Down
3 changes: 0 additions & 3 deletions public/lang/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,9 +630,6 @@
"discoverCollections_conferencesHeading": {
"string": "Conferences"
},
"discoverCollections_featuredCollectionHeading": {
"string": "Featured Collection"
},
"discoverCollections_storySeasonsHeading": {
"string": "Stories"
},
Expand Down
26 changes: 2 additions & 24 deletions src/containers/discover/collections.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import React from 'react';
import { FormattedMessage } from 'react-intl';

import LineHeading from '~components/atoms/lineHeading';
import CardFavoriteEntity from '~components/molecules/card/favoriteEntity';
import Audiobooks from '~src/components/organisms/cardSlider/section/audiobooks';
import Conferences from '~src/components/organisms/cardSlider/section/conferences';
import Presenters from '~src/components/organisms/cardSlider/section/presenters';
Expand All @@ -13,34 +11,15 @@ import StorySeasons from '~src/components/organisms/cardSlider/section/storySeas
import Topics from '~src/components/organisms/cardSlider/section/topics';

import { GetDiscoverCollectionsPageDataQuery } from './__generated__/collections';
import styles from './collections.module.scss';

export type IDiscoverCollectionsProps = GetDiscoverCollectionsPageDataQuery;

export default function DiscoverCollections({
websiteFeaturedCollection,
}: IDiscoverCollectionsProps): JSX.Element {
export default function DiscoverCollections(): JSX.Element {
return (
<div>
{websiteFeaturedCollection && (
<>
<LineHeading variant="overline">
<FormattedMessage
id="discoverCollections_featuredCollectionHeading"
defaultMessage="Featured Collection"
/>
</LineHeading>
<div className={styles.featured}>
<CardFavoriteEntity
entity={websiteFeaturedCollection}
disableSequenceStack
/>
</div>
</>
)}

<Presenters />
<Topics />
<Series />
<Audiobooks />
<Conferences
heading={
Expand All @@ -61,7 +40,6 @@ export default function DiscoverCollections({
}
/>
<ScriptureSongs />
<Series />
</div>
);
}
Loading