Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Av 498 prompt users with warning message when clicking on continue as guest website and mobile browser #470

Merged
merged 13 commits into from
Sep 22, 2023
Merged

Av 498 prompt users with warning message when clicking on continue as guest website and mobile browser #470

merged 13 commits into from
Sep 22, 2023

Conversation

okeinom
Copy link
Collaborator

@okeinom okeinom commented Sep 19, 2023

No description provided.

@vercel
Copy link

vercel bot commented Sep 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
audioverse-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 5:00pm

@github-actions
Copy link

github-actions bot commented Sep 19, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for audioverse-next

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 179.09 KB (🟢 -17.7 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eighty-six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (225 KB)
/404 1.02 KB 180.12 KB 80.05% (🟢 -0.14%)
/[language] 9.8 KB 188.89 KB 83.95% (🟢 -0.41%)
/[language]/about/1/[[...slugs]] 3 KB 182.09 KB 80.93% (🟢 -0.14%)
/[language]/about/12/[[...slugs]] 3.67 KB 182.76 KB 81.23% (🟢 -0.16%)
/[language]/about/13/[[...slugs]] 4.63 KB 183.73 KB 81.66% (🟢 -0.18%)
/[language]/about/7/[[...slugs]] 3.68 KB 182.77 KB 81.23% (🟢 -0.18%)
/[language]/about/[id]/[[...slugs]] 1.83 KB 180.92 KB 80.41% (🟢 -0.22%)
/[language]/account/login 40.76 KB 219.85 KB 97.71% (🟢 -3.46%)
/[language]/account/logout 518 B 179.6 KB 79.82% (🟢 -0.06%)
/[language]/account/preferences 43.83 KB 222.92 KB 99.08% (🟢 -3.76%)
/[language]/account/profile 43.17 KB 222.26 KB 98.78% (🟢 -3.64%)
/[language]/account/register 41.7 KB 220.8 KB 98.13% (🟢 -3.52%)
/[language]/account/reset 3.94 KB 183.03 KB 81.35% (🟢 -0.17%)
/[language]/bibles 3.35 KB 182.45 KB 81.09% (🟢 -0.36%)
/[language]/bibles/[id]/[[...slugs]] 3.25 KB 182.35 KB 81.04% (🟢 -0.38%)
/[language]/bibles/[id]/[book]/[chapter] 13.89 KB 192.99 KB 85.77% (🟢 -0.78%)
/[language]/bibles/chapters/[id]/[[...slugs]] 18.62 KB 197.71 KB 87.87% (🟢 -1.13%)
/[language]/blog/[id]/[[...slugs]] 3.71 KB 182.8 KB 81.24% (🟢 -0.32%)
/[language]/blog/page/[i] 3.79 KB 182.88 KB 81.28% (🟢 -0.37%)
/[language]/books/[id]/[[...slugs]] 5.37 KB 184.47 KB 81.98% (🟢 -0.56%)
/[language]/books/[id]/feed.xml 631 B 179.71 KB 79.87% (🟢 -0.09%)
/[language]/books/page/[i] 2.94 KB 182.03 KB 80.90% (🟢 -0.30%)
/[language]/books/tracks/[id]/[[...slugs]] 19.41 KB 198.51 KB 88.23% (🟢 -1.26%)
/[language]/conferences/[id]/[[...slug]] 5.12 KB 184.21 KB 81.87% (🟢 -0.43%)
/[language]/conferences/[id]/feed.xml 268 B 179.35 KB 79.71% (🟢 -0.02%)
/[language]/conferences/[id]/presenters/page/[i] 3.28 KB 182.38 KB 81.06% (🟢 -0.37%)
/[language]/conferences/[id]/sequences/page/[i] 3.28 KB 182.37 KB 81.06% (🟢 -0.36%)
/[language]/conferences/[id]/teachings/page/[i] 3.28 KB 182.38 KB 81.06% (🟢 -0.37%)
/[language]/conferences/page/[i] 2.95 KB 182.04 KB 80.91% (🟢 -0.31%)
/[language]/contact/[type] 3.15 KB 182.24 KB 81.00% (🟢 -0.19%)
/[language]/discover 7.88 KB 186.98 KB 83.10% (🟢 -0.62%)
/[language]/discover/collections 6.64 KB 185.73 KB 82.55% (🟢 -0.49%)
/[language]/embed/media/[id] 11.71 KB 190.8 KB 84.80% (🟢 -0.64%)
/[language]/give 3.13 KB 182.23 KB 80.99% (🟢 -0.14%)
/[language]/library 45.28 KB 224.37 KB 99.72% (🟢 -3.75%)
/[language]/library/history 46.33 KB 225.42 KB 100.19% (🟢 -3.85%)
/[language]/library/playlist/[id] 2.69 KB 181.78 KB 80.79% (🟢 -0.31%)
/[language]/library/playlists 47.07 KB 226.16 KB 100.52% (🟢 -3.88%)
/[language]/page/[id]/[[...slugs]] 1.41 KB 180.5 KB 80.22% (🟢 -0.19%)
/[language]/presenters/[id]/[[...slug]] 4.95 KB 184.04 KB 81.80% (🟢 -0.44%)
/[language]/presenters/[id]/appears/page/[i] 3.4 KB 182.49 KB 81.11% (🟢 -0.37%)
/[language]/presenters/[id]/feed.xml 267 B 179.35 KB 79.71% (🟢 -0.02%)
/[language]/presenters/[id]/sequences/page/[i] 3.4 KB 182.49 KB 81.11% (🟢 -0.37%)
/[language]/presenters/[id]/teachings/page/[i] 3.53 KB 182.63 KB 81.17% (🟢 -0.38%)
/[language]/presenters/[id]/top 1.9 KB 181 KB 80.44% (🟢 -0.27%)
/[language]/presenters/all 2.37 KB 181.47 KB 80.65% (🟢 -0.23%)
/[language]/presenters/letter/[letter] 2.49 KB 181.58 KB 80.70% (🟢 -0.24%)
/[language]/releases/[id] 2.8 KB 181.89 KB 80.84% (🟢 -0.28%)
/[language]/search 258 B 179.34 KB 79.71% (🟢 -0.04%)
/[language]/search/collections/page/[i] 3.01 KB 182.1 KB 80.93% (🟢 -0.31%)
/[language]/search/persons/page/[i] 3.01 KB 182.1 KB 80.93% (🟢 -0.31%)
/[language]/search/sequences/page/[i] 3.01 KB 182.1 KB 80.93% (🟢 -0.31%)
/[language]/search/sponsors/page/[i] 3.01 KB 182.1 KB 80.93% (🟢 -0.31%)
/[language]/search/teachings/page/[i] 3 KB 182.1 KB 80.93% (🟢 -0.31%)
/[language]/series/[id]/[[...slug]] 5.38 KB 184.47 KB 81.99% (🟢 -0.57%)
/[language]/series/[id]/feed.xml 264 B 179.35 KB 79.71% (🟢 -0.02%)
/[language]/series/page/[i] 2.94 KB 182.04 KB 80.91% (🟢 -0.31%)
/[language]/songs/[id]/[[...slugs]] 19.41 KB 198.5 KB 88.22% (🟢 -1.25%)
/[language]/songs/albums 4.66 KB 183.75 KB 81.67% (🟢 -0.50%)
/[language]/songs/albums/[id]/[[...slugs]] 5.38 KB 184.47 KB 81.99% (🟢 -0.57%)
/[language]/songs/albums/[id]/feed.xml 271 B 179.36 KB 79.71% (🟢 -0.02%)
/[language]/songs/book/[book] 6.28 KB 185.37 KB 82.39% (🟢 -0.66%)
/[language]/songs/book/[book]/[id]/[[...slugs]] 19.57 KB 198.66 KB 88.29% (🟢 -1.27%)
/[language]/sponsors/[id]/[[...slugs]] 4.76 KB 183.85 KB 81.71% (🟢 -0.45%)
/[language]/sponsors/[id]/conferences/page/[i] 3.48 KB 182.57 KB 81.14% (🟢 -0.38%)
/[language]/sponsors/[id]/series/page/[i] 3.47 KB 182.57 KB 81.14% (🟢 -0.38%)
/[language]/sponsors/[id]/teachings/feed.xml 274 B 179.36 KB 79.72% (🟢 -0.03%)
/[language]/sponsors/[id]/teachings/page/[i] 3.61 KB 182.71 KB 81.20% (🟢 -0.40%)
/[language]/sponsors/all 2.17 KB 181.26 KB 80.56% (🟢 -0.23%)
/[language]/sponsors/letter/[letter] 2.27 KB 181.36 KB 80.61% (🟢 -0.24%)
/[language]/stories/[id]/[[...slugs]] 19.41 KB 198.5 KB 88.22% (🟢 -1.25%)
/[language]/stories/albums/[id]/[[...slugs]] 5.38 KB 184.47 KB 81.99% (🟢 -0.57%)
/[language]/stories/albums/[id]/feed.xml 272 B 179.36 KB 79.71% (🟢 -0.02%)
/[language]/stories/albums/page/[i] 2.38 KB 181.47 KB 80.65% (🟢 -0.21%)
/[language]/teachings/[id]/[[...slug]] 19.41 KB 198.5 KB 88.22% (🟢 -1.25%)
/[language]/teachings/all/feed.xml 267 B 179.35 KB 79.71% (🟢 -0.02%)
/[language]/teachings/all/page/[i] 3.78 KB 182.88 KB 81.28% (🟢 -0.37%)
/[language]/teachings/audio/page/[i] 3.78 KB 182.88 KB 81.28% (🟢 -0.37%)
/[language]/teachings/trending/all 2.94 KB 182.03 KB 80.90% (🟢 -0.35%)
/[language]/teachings/trending/audio 2.41 KB 181.5 KB 80.67% (🟢 -0.28%)
/[language]/teachings/trending/video 2.41 KB 181.5 KB 80.67% (🟢 -0.28%)
/[language]/teachings/video/page/[i] 3.78 KB 182.88 KB 81.28% (🟢 -0.37%)
/[language]/testimonies/page/[i] 3.08 KB 182.17 KB 80.97% (🟢 -0.24%)
/[language]/topics/[id]/[[...slugs]] 4.84 KB 183.93 KB 81.75% (🟢 -0.43%)
/[language]/topics/page/[i] 3.38 KB 182.47 KB 81.10% (🟢 -0.27%)
/_error 1.18 KB 180.27 KB 80.12% (🟢 -0.05%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

narthur
narthur previously requested changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@narthur narthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Message me in Slack if you have any questions.

package.json Show resolved Hide resolved
src/components/molecules/buttonGuest.tsx Show resolved Hide resolved
src/components/molecules/buttonGuest.tsx Show resolved Hide resolved
src/containers/account/register.spec.tsx Show resolved Hide resolved
src/containers/sermon/detail.spec.tsx Show resolved Hide resolved
@narthur
Copy link
Collaborator

narthur commented Sep 20, 2023

@okeinom It also looks like you need to run npm run intl:extract && npm run intl:compile

@github-actions
Copy link

github-actions bot commented Sep 20, 2023 •
edited
Loading

Lighthouse Results

@jlaverde77 jlaverde77 requested a review from narthur September 20, 2023 22:03
@jlaverde77 jlaverde77 merged commit c36696e into master Sep 22, 2023
9 of 10 checks passed
@jlaverde77 jlaverde77 deleted the AV-498-Prompt-Users-with-warning-message-when-clicking-on-Continue-as-Guest-Website-and-Mobile-Browser branch September 22, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaverde77 jlaverde77 jlaverde77 approved these changes

@narthur narthur Awaiting requested review from narthur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@okeinom @narthur @jlaverde77 @okeino