Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace React with Preact in client prod builds #160

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattleff
Copy link
Contributor

This is a scary change...

@mattleff mattleff self-assigned this Dec 22, 2021
@vercel
Copy link

vercel bot commented Dec 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/audioverse/audioverse-next/CMrAkyo7NQqK8G6u1MMXTNPEqjya
✅ Preview: https://audioverse-next-git-perf-preact-audioverse.vercel.app

@github-actions
Copy link

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 113.9 KB (🟢 -33.7 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eighty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (225 KB)
/404 15.41 KB 129.32 KB 57.47% (🟡 +0.03%)
/[language] 37.87 KB 151.77 KB 67.45% (🟡 +0.30%)
/[language]/about/1/[[...slugs]] 3.35 KB 117.25 KB 52.11% (+/- <0.01%)
/[language]/about/12/[[...slugs]] 3.76 KB 117.66 KB 52.30% (+/- <0.01%)
/[language]/about/13/[[...slugs]] 5.26 KB 119.16 KB 52.96% (🟡 +0.01%)
/[language]/about/7/[[...slugs]] 3.88 KB 117.78 KB 52.35% (+/- <0.01%)
/[language]/about/[id]/[[...slugs]] 16.5 KB 130.41 KB 57.96% (🟡 +0.02%)
/[language]/account/login 41.14 KB 155.04 KB 68.91% (🟡 +0.02%)
/[language]/account/logout 452 B 114.34 KB 50.82% (+/- <0.01%)
/[language]/account/preferences 43.57 KB 157.47 KB 69.99% (🟡 +0.02%)
/[language]/account/profile 43.04 KB 156.94 KB 69.75% (🟡 +0.03%)
/[language]/account/register 42.59 KB 156.49 KB 69.55% (🟡 +0.02%)
/[language]/account/reset 4.05 KB 117.95 KB 52.42% (🟡 +0.01%)
/[language]/bibles 35.07 KB 148.98 KB 66.21% (🟡 +0.30%)
/[language]/bibles/[id]/[[...slugs]] 21.39 KB 135.29 KB 60.13% (🟡 +0.03%)
/[language]/bibles/[id]/[book]/[chapter] 27.44 KB 141.34 KB 62.82% (🟡 +0.04%)
/[language]/bibles/chapters/[id]/[[...slugs]] 28.62 KB 142.52 KB 63.34% (🟡 +0.04%)
/[language]/blog/[id]/[[...slugs]] 21.01 KB 134.91 KB 59.96% (🟡 +0.03%)
/[language]/blog/page/[i] 21.17 KB 135.07 KB 60.03% (🟡 +0.03%)
/[language]/books/[id]/[[...slugs]] 23.29 KB 137.19 KB 60.98% (🟡 +0.03%)
/[language]/books/[id]/feed.xml 1.07 KB 114.97 KB 51.10% (+/- <0.01%)
/[language]/books/page/[i] 21.54 KB 135.45 KB 60.20% (🟡 +0.03%)
/[language]/books/tracks/[id]/[[...slugs]] 35.87 KB 149.77 KB 66.57% (🟡 +0.05%)
/[language]/conferences/[id]/[[...slug]] 29.32 KB 143.22 KB 63.65% (🟡 +0.05%)
/[language]/conferences/[id]/feed.xml 274 B 114.17 KB 50.74% (+/- <0.01%)
/[language]/conferences/[id]/presenters/page/[i] 21.37 KB 135.27 KB 60.12% (🟡 +0.03%)
/[language]/conferences/[id]/sequences/page/[i] 23.02 KB 136.92 KB 60.85% (🟡 +0.04%)
/[language]/conferences/[id]/teachings/page/[i] 19.76 KB 133.66 KB 59.41% (🟡 +0.03%)
/[language]/conferences/page/[i] 27.56 KB 141.46 KB 62.87% (🟡 +0.04%)
/[language]/contact/[type] 3.06 KB 116.96 KB 51.98% (🟡 +0.01%)
/[language]/discover 26.05 KB 139.95 KB 62.20% (🟡 +0.03%)
/[language]/discover/collections 27.49 KB 141.39 KB 62.84% (🟡 +0.04%)
/[language]/embed/media/[id] 25.04 KB 138.94 KB 61.75% (🟡 +0.04%)
/[language]/give 3.2 KB 117.1 KB 52.05% (+/- <0.01%)
/[language]/library 78.54 KB 192.44 KB 85.53% (🟡 +0.33%)
/[language]/library/history 79.44 KB 193.34 KB 85.93% (🟡 +0.33%)
/[language]/library/playlist/[id] 20.89 KB 134.79 KB 59.91% (🟡 +0.03%)
/[language]/library/playlists 80.25 KB 194.15 KB 86.29% (🟡 +0.33%)
/[language]/presenters/[id]/[[...slug]] 29.88 KB 143.79 KB 63.90% (🟡 +0.04%)
/[language]/presenters/[id]/appears/page/[i] 29.13 KB 143.04 KB 63.57% (🟡 +0.04%)
/[language]/presenters/[id]/feed.xml 271 B 114.17 KB 50.74% (+/- <0.01%)
/[language]/presenters/[id]/sequences/page/[i] 22.99 KB 136.89 KB 60.84% (🟡 +0.03%)
/[language]/presenters/[id]/teachings/page/[i] 20.03 KB 133.93 KB 59.52% (🟡 +0.03%)
/[language]/presenters/[id]/top 18.47 KB 132.37 KB 58.83% (🟡 +0.03%)
/[language]/presenters/letter/[letter] 17.24 KB 131.14 KB 58.29% (🟡 +0.02%)
/[language]/releases/[id] 17.22 KB 131.12 KB 58.28% (🟡 +0.02%)
/[language]/search 31.81 KB 145.71 KB 64.76% (🟡 +0.04%)
/[language]/search/collections/page/[i] 27.59 KB 141.5 KB 62.89% (🟡 +0.04%)
/[language]/search/persons/page/[i] 19.95 KB 133.85 KB 59.49% (🟡 +0.03%)
/[language]/search/sequences/page/[i] 21.59 KB 135.5 KB 60.22% (🟡 +0.03%)
/[language]/search/sponsors/page/[i] 19.22 KB 133.13 KB 59.17% (🟡 +0.03%)
/[language]/search/teachings/page/[i] 18.11 KB 132.02 KB 58.67% (🟡 +0.03%)
/[language]/series/[id]/[[...slug]] 23.29 KB 137.2 KB 60.98% (🟡 +0.03%)
/[language]/series/[id]/feed.xml 268 B 114.16 KB 50.74% (+/- <0.01%)
/[language]/series/page/[i] 21.55 KB 135.45 KB 60.20% (🟡 +0.04%)
/[language]/songs/[id]/[[...slugs]] 35.87 KB 149.77 KB 66.56% (🟡 +0.06%)
/[language]/songs/albums 17.58 KB 131.49 KB 58.44% (🟡 +0.02%)
/[language]/songs/albums/[id]/[[...slugs]] 23.3 KB 137.2 KB 60.98% (🟡 +0.03%)
/[language]/songs/albums/[id]/feed.xml 272 B 114.17 KB 50.74% (+/- <0.01%)
/[language]/songs/book/[book] 21.08 KB 134.98 KB 59.99% (🟡 +0.04%)
/[language]/songs/book/[book]/[id]/[[...slugs]] 36.02 KB 149.92 KB 66.63% (🟡 +0.06%)
/[language]/sponsors/[id]/[[...slugs]] 28.97 KB 142.87 KB 63.50% (🟡 +0.04%)
/[language]/sponsors/[id]/conferences/page/[i] 28.37 KB 142.27 KB 63.23% (🟡 +0.04%)
/[language]/sponsors/[id]/series/page/[i] 22.26 KB 136.16 KB 60.52% (🟡 +0.03%)
/[language]/sponsors/[id]/teachings/feed.xml 276 B 114.17 KB 50.74% (+/- <0.01%)
/[language]/sponsors/[id]/teachings/page/[i] 19.26 KB 133.16 KB 59.18% (🟡 +0.03%)
/[language]/sponsors/letter/[letter] 17.07 KB 130.97 KB 58.21% (🟡 +0.03%)
/[language]/stories/[id]/[[...slugs]] 35.87 KB 149.77 KB 66.56% (🟡 +0.06%)
/[language]/stories/albums/[id]/[[...slugs]] 23.3 KB 137.2 KB 60.98% (🟡 +0.03%)
/[language]/stories/albums/[id]/feed.xml 273 B 114.17 KB 50.74% (+/- <0.01%)
/[language]/stories/albums/page/[i] 21.56 KB 135.46 KB 60.20% (🟡 +0.04%)
/[language]/teachings/[id]/[[...slug]] 35.87 KB 149.77 KB 66.57% (🟡 +0.05%)
/[language]/teachings/all/feed.xml 269 B 114.17 KB 50.74% (+/- <0.01%)
/[language]/teachings/all/page/[i] 19.14 KB 133.04 KB 59.13% (🟡 +0.03%)
/[language]/teachings/audio/page/[i] 19.14 KB 133.04 KB 59.13% (🟡 +0.03%)
/[language]/teachings/trending/all 17.79 KB 131.69 KB 58.53% (🟡 +0.03%)
/[language]/teachings/trending/audio 17.4 KB 131.3 KB 58.36% (🟡 +0.02%)
/[language]/teachings/trending/video 17.4 KB 131.3 KB 58.35% (🟡 +0.03%)
/[language]/teachings/video/page/[i] 19.14 KB 133.04 KB 59.13% (🟡 +0.03%)
/[language]/testimonies/page/[i] 3.22 KB 117.12 KB 52.05% (🟡 +0.01%)
/_error 1.08 KB 114.98 KB 51.10% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant