Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 22050 Hz as flavor, deprecate 22500 Hz #470

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

ChristianGeng
Copy link
Member

@ChristianGeng ChristianGeng commented Nov 22, 2024

closes #468

Summary by Sourcery

Change the supported sampling rate from 22500 Hz to 22050 Hz in the codebase and update the documentation accordingly.

Enhancements:

  • Update the sampling rate from 22500 Hz to 22050 Hz across multiple files for consistency.

Documentation:

  • Update documentation to reflect the change in supported sampling rates from 22500 Hz to 22050 Hz.

Copy link
Contributor

sourcery-ai bot commented Nov 22, 2024

Reviewer's Guide by Sourcery

This PR corrects a sampling rate value from 22500 Hz to 22050 Hz across the codebase. The change is made consistently in function docstrings and the list of supported sampling rates.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update incorrect sampling rate value in supported sampling rates list
  • Change sampling rate value from 22500 Hz to 22050 Hz
  • Update docstrings to reflect the correct sampling rate
audb/core/api.py
audb/core/load.py
audb/core/define.py
audb/core/flavor.py
audb/core/stream.py
docs/load.rst

Assessment against linked issues

Issue Objective Addressed Explanation
#468 Deprecate/remove 22,500 Hz sampling rate
#468 Add 22,050 Hz sampling rate

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ChristianGeng - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ChristianGeng ChristianGeng requested a review from hagenw November 22, 2024 08:33
@hagenw hagenw force-pushed the sr-22500Hz-to-22050Hz branch from 5118098 to 75296b4 Compare December 6, 2024 07:27
@hagenw hagenw changed the title Change sr from 22500 to 22050 in all files. Add 22050 Hz as flavor, deprecate 22500 Hz Dec 6, 2024
Copy link
Member

@hagenw hagenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine now.

@hagenw hagenw merged commit eb5b27e into main Dec 6, 2024
10 checks passed
@hagenw hagenw deleted the sr-22500Hz-to-22050Hz branch December 6, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate 22,500 Hz sampling rate and add 22,050 Hz instead
2 participants