Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace artifactory by minio for public repo #450

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Replace artifactory by minio for public repo #450

wants to merge 3 commits into from

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Oct 30, 2024

Adds support for S3 and MinIO backends, and switches the default repository to one hosted on AWS S3. It continues to support Artifactory backends.

Summary by Sourcery

Add support for S3 and MinIO backends and switch the default repository to AWS S3, while continuing to support Artifactory backends.

New Features:

  • Add support for S3 and MinIO backends.

Enhancements:

  • Switch the default repository to one hosted on AWS S3 while maintaining support for Artifactory backends.

@hagenw hagenw marked this pull request as draft October 30, 2024 14:08
Copy link

sourcery-ai bot commented Oct 30, 2024

Reviewer's Guide by Sourcery

This PR implements the migration from Artifactory to MinIO/S3 for public repositories. The changes primarily involve updating repository configurations and backend-specific logic. The implementation maintains backward compatibility with Artifactory while introducing S3 capabilities, with the default public repository now pointing to an AWS S3 endpoint.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update default repository configuration from Artifactory to S3
  • Change default repository name from 'data-public' to 'audb-public'
  • Update backend from 'artifactory' to 's3'
  • Change host URL from Artifactory to AWS S3 endpoint
  • Update repository configuration in YAML file
audb/core/etc/audb.yaml
audb/core/conftest.py
tests/conftest.py
Modify backend-specific logic in core API functions
  • Update example outputs to reflect new S3 backend
  • Add pragma nocover for Artifactory-specific code paths
  • Adjust exception handling for backend operations
  • Update repository reference documentation
audb/core/api.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenw - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hagenw hagenw marked this pull request as ready for review November 29, 2024 15:48
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenw - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant