fix issue #43: added enhanced-overriden-template #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should be backwards compatible. It allows a someone overriding the templates to use the same directory structure that hip test does. It allows for use of different actionwords.hbs in different context (step_defintions vs actionwords). The only issue I found which may or may not be an easy of use design flaw is that in my use case I needed to copy the original cucumber/java/actionwords.hbs into my override folder because the wrong template was being picked up. This is not caused by my change but by the search path design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should be backwards compatible. It allows a someone overriding the templates to use the same directory structure that hip test does. It allows for use of different actionwords.hbs in different context (step_defintions vs actionwords).
The only issue I found which may or may not be an easy of use design flaw is that in my use case I needed to copy the original cucumber/java/actionwords.hbs into my override folder because the wrong template was being picked up. This is not caused by my change but by the search path design.