Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APP-2879] Force show creatives on client apps for testing #97

Merged
merged 8 commits into from
Jun 21, 2024

Conversation

vespinola
Copy link

@vespinola vespinola commented Jun 17, 2024

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Jira Link

What's new?

  • Updated trigger signature to receive creative ID.
    • func trigger(_ view: UIView)
    • func trigger(_ view: UIView, handler: ATTNCreativeTriggerCompletionHandler?)
    • func trigger(_ view: UIView, creativeId: String)
    • func trigger(_ view: UIView, creativeId: String, handler: ATTNCreativeTriggerCompletionHandler?)
  • Added public var skipFatigueOnCreative: Bool = false in ATTNSDK.
  • Added SKIP_FATIGUE_ON_CREATIVE environment object for UI Automation or even in CI.

Testing

  • Added unit test for new properties

Screenshots

@vespinola vespinola self-assigned this Jun 17, 2024
@vespinola vespinola marked this pull request as ready for review June 20, 2024 18:14
@vespinola vespinola merged commit 1a2d81c into attentive-mobile:main Jun 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants