Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APP-2984] App SDK CocoaPods Download Error #91

Merged
merged 3 commits into from
Jun 12, 2024
Merged

[APP-2984] App SDK CocoaPods Download Error #91

merged 3 commits into from
Jun 12, 2024

Conversation

vespinola
Copy link

@vespinola vespinola commented Jun 11, 2024 •
edited
Loading

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Jira Link

What's new?

  • Deprecated attentive-ios-sdk podspec.
  • Created new ATTNSDKFramework podspec
  • Updated README

Regarding the new podspec, the idea is to display a warning when pod install or pod update is executed. The deprecating warning will be displayed on the project Podfile if Swiftlint is installed, but this is not up to SDK.

Testing

  • Unit tests pass locally and in CI
  • UI Tests pass locally and in CI
  • Manual testing with Examples Apps
  • Manual testing with other Apps I created on my end

Screenshots

Screenshot 2024-06-11 at 3 41 15 PM

@vespinola vespinola added enhancement New feature or request featureBranch labels Jun 11, 2024
@vespinola vespinola self-assigned this Jun 11, 2024
@vespinola vespinola marked this pull request as ready for review June 12, 2024 15:06
jasonaden
jasonaden approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@jasonaden jasonaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vespinola vespinola merged commit 835836f into attentive-mobile:swift-migration Jun 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonaden jasonaden jasonaden approved these changes

Assignees

@vespinola vespinola

Labels
enhancement New feature or request featureBranch
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vespinola @jasonaden