Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rsmith/support swift #74

Merged
merged 26 commits into from
Feb 21, 2024
Merged

Rsmith/support swift #74

merged 26 commits into from
Feb 21, 2024

Conversation

rsmith-attentive
Copy link
Contributor

@rsmith-attentive rsmith-attentive commented Feb 2, 2024

Adds Package.swift files in order to support users using our app via SPM (Swift Package Manager) instead of cocoapods

Additionally, updates our ExampleSwift app to depend on the SDK via SPM in order to ensure the e2e experience works as expected for users.

isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/attentive-mobile/attentive-ios-sdk";
requirement = {
branch = "rsmith/support-swift";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will adapt this to be main in a new PR with version specified once this is merged

"package": "ATTNSDKFramework",
"repositoryURL": "https://github.com/attentive-mobile/attentive-ios-sdk",
"state": {
"branch": "rsmith/support-swift",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will adapt this to be main once this PR is merged

targets: ["ExampleSwift"]),
],
dependencies: [
.package(url: "https://github.com/attentive-mobile/attentive-ios-sdk", .branch("rsmith/support-swift"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will adapt this to point to main once this PR is merged

@rsmith-attentive rsmith-attentive marked this pull request as ready for review February 21, 2024 14:35
@rsmith-attentive rsmith-attentive merged commit cd9444f into main Feb 21, 2024
2 checks passed
@rsmith-attentive rsmith-attentive deleted the rsmith/support-swift branch February 21, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants