Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce complexity in ATTNSDK #109

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Reduce complexity in ATTNSDK #109

merged 3 commits into from
Jul 8, 2024

Conversation

vespinola
Copy link

@vespinola vespinola commented Jul 4, 2024 •
edited
Loading

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Jira Link

What's new?

Created a new class to hide WebKit methods from the final client. The logic is the same, but the code is on ATTNWebViewHandler.

Testing

Screenshots

Before

Screenshot 2024-07-04 at 2 37 46 PM

After

Screenshot 2024-07-04 at 2 36 15 PM

@vespinola vespinola added the enhancement New feature or request label Jul 4, 2024
@vespinola vespinola self-assigned this Jul 4, 2024
@vespinola vespinola marked this pull request as ready for review July 5, 2024 13:39
@vespinola vespinola merged commit c48edeb into attentive-mobile:release/1.0.0 Jul 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TWaltze TWaltze TWaltze approved these changes

Assignees

@vespinola vespinola

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vespinola @TWaltze