122064: remove console.logs

atmire · Dec 10, 2024 · 6a91314 · 6a91314
1 parent 7208383
commit 6a91314
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/src/app/browse-by/browse-by-date-page/browse-by-date-page.component.spec.ts b/src/app/browse-by/browse-by-date-page/browse-by-date-page.component.spec.ts
@@ -65,7 +65,8 @@ describe('BrowseByDatePageComponent', () => {
    const mockBrowseService = {
      getBrowseEntriesFor: (options: BrowseEntrySearchOptions) => toRemoteData([]),
      getBrowseItemsFor: (value: string, options: BrowseEntrySearchOptions) => toRemoteData([firstItem]),
-     getFirstItemFor: (definition: string, scope?: string, sortDirection?: SortDirection) => null
+     getFirstItemFor: (definition: string, scope?: string, sortDirection?: SortDirection) => null,
+     getConfiguredSortDirection: () => observableOf(SortDirection.DESC),
    };
 
   const mockDsoService = {

diff --git a/src/app/browse-by/browse-by-date-page/browse-by-date-page.component.ts b/src/app/browse-by/browse-by-date-page/browse-by-date-page.component.ts
@@ -64,6 +64,7 @@ export class BrowseByDatePageComponent extends BrowseByMetadataPageComponent {
         })).subscribe(({ params, currentPage, currentSort }) => {
           const metadataKeys = params.browseDefinition ? params.browseDefinition.metadataKeys : this.defaultMetadataKeys;
           this.startsWith = +params.startsWith || params.startsWith;
+          this.browseId = params.id || this.defaultBrowseId;
           const searchOptions = browseParamsToOptions(params, currentPage, currentSort, this.browseId, this.fetchThumbnails);
           this.updatePageWithItems(searchOptions, this.value, undefined);
           this.updateParent(params.scope);

diff --git a/src/app/browse-by/browse-by-metadata-page/browse-by-metadata-page.component.spec.ts b/src/app/browse-by/browse-by-metadata-page/browse-by-metadata-page.component.spec.ts
@@ -88,7 +88,8 @@ describe('BrowseByMetadataPageComponent', () => {
 
   const mockBrowseService = {
     getBrowseEntriesFor: (options: BrowseEntrySearchOptions) => toRemoteData(mockEntries),
-    getBrowseItemsFor: (value: string, options: BrowseEntrySearchOptions) => toRemoteData(mockItems)
+    getBrowseItemsFor: (value: string, options: BrowseEntrySearchOptions) => toRemoteData(mockItems),
+    getConfiguredSortDirection: () => observableOf(SortDirection.ASC),
   };
 
   const mockDsoService = {

diff --git a/src/app/browse-by/browse-by-title-page/browse-by-title-page.component.spec.ts b/src/app/browse-by/browse-by-title-page/browse-by-title-page.component.spec.ts
@@ -22,6 +22,7 @@ import { PaginationService } from '../../core/pagination/pagination.service';
 import { PaginationServiceStub } from '../../shared/testing/pagination-service.stub';
 import { APP_CONFIG } from '../../../config/app-config.interface';
 import { environment } from '../../../environments/environment';
+import { SortDirection } from '../../core/cache/models/sort-options.model';
 
 
 describe('BrowseByTitlePageComponent', () => {
@@ -54,7 +55,8 @@ describe('BrowseByTitlePageComponent', () => {
 
   const mockBrowseService = {
     getBrowseItemsFor: () => toRemoteData(mockItems),
-    getBrowseEntriesFor: () => toRemoteData([])
+    getBrowseEntriesFor: () => toRemoteData([]),
+    getConfiguredSortDirection: () => observableOf(SortDirection.ASC),
   };
 
   const mockDsoService = {