This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
generated from atls-academy/template
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .pnp.cjs # landing/entrypoints/renderer/package.json # landing/fragments/landing-technologies/package.json # landing/fragments/landing-technologies/src/technologies-list/technologies.list.ts # landing/fragments/landing-technologies/src/technologies.component.tsx # yarn.lock
# Conflicts: # landing/pages/index-page/src/index.page.tsx
oxiqod
approved these changes
Oct 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
насчет остатка месседжей, внеси тогда когда Никита добавит
а так, больше придраться не к чему, молодец)
Nelfimov
suggested changes
Oct 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Добить оставшиеся запросы
Nelfimov
suggested changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Баг с анимацией параллакса, заголовки не "едут" вместе с блоком:
Screen.Recording.2023-10-09.at.11.05.14.mov
Nelfimov
suggested changes
Oct 9, 2023
Nelfimov
approved these changes
Oct 10, 2023
# Conflicts: # landing/fragments/landing-library/src/cards/card/card.component.tsx # landing/fragments/landing-library/src/library.component.tsx # landing/fragments/landing-navigation/src/drawer/drawer-card/indent/indent.component.tsx # landing/fragments/landing-navigation/src/drawer/drawer-card/indent/indent.interfaces.ts # landing/fragments/landing-technologies/src/technologies.component.tsx
TorinAsakura
approved these changes
Oct 15, 2023
Signed-off-by: Andrew Ghostuhin <[email protected]>
пофикси конфликты и 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #20