Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

feat/landing-fifth-step #17

Merged
merged 47 commits into from
Sep 27, 2023
Merged

feat/landing-fifth-step #17

merged 47 commits into from
Sep 27, 2023

Conversation

Mirved64
Copy link
Contributor

Close #16

@Mirved64 Mirved64 added the enhancement New feature or request label Aug 25, 2023
@Mirved64 Mirved64 self-assigned this Aug 25, 2023
@Mirved64 Mirved64 changed the base branch from master to feat/landing-fourth-step August 25, 2023 16:43
@Mirved64

This comment was marked as resolved.

Sign in to view
@Nelfimov

This comment was marked as resolved.

Sign in to view
@Mirved64 Mirved64 requested a review from oxiqod August 31, 2023 10:22
@Mirved64 Mirved64 removed the request for review from oxiqod September 5, 2023 06:57
@Mirved64 Mirved64 requested a review from oxiqod September 5, 2023 15:11
oxiqod
oxiqod suggested changes Sep 6, 2023
View reviewed changes
landing/fragments/landing-library/src/library.component.tsx Outdated Show resolved Hide resolved
ui/button/src/attachment/attachment.interfaces.ts Outdated Show resolved Hide resolved
ui/input/src/attachment/attachment.interfaces.ts Outdated Show resolved Hide resolved
ui/input/src/input.interfaces.ts Outdated Show resolved Hide resolved
ui/navbar/package.json Outdated Show resolved Hide resolved
@Nelfimov
Copy link
Contributor

WS тоже без интерфейса не пропсах пишет any

У меня есть:

Screenshot 2023-09-11 at 18 51 25

Проверь настройки, у тебя даже для стейта нет интерфеса initialState

Base automatically changed from feat/landing-fourth-step to master September 11, 2023 23:49
@TorinAsakura TorinAsakura requested review from a team and removed request for TorinAsakura, Nelfimov and a team September 11, 2023 23:51
oxiqod
oxiqod approved these changes Sep 23, 2023
View reviewed changes
Copy link

@oxiqod oxiqod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

по проекту сплошное покрытие типизацией, мне есть чему у тебя поучиться) молодец!

ui/accordion/src/accordion.component.tsx Outdated Show resolved Hide resolved
ui/drawer/src/renderer/renderer.component.tsx Show resolved Hide resolved
ui/logo/src/logo.component.tsx Outdated Show resolved Hide resolved
@oxiqod oxiqod removed their request for review September 25, 2023 12:58
TorinAsakura
TorinAsakura suggested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@TorinAsakura TorinAsakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

отпадно! воистину!! чуть-чуть прям дотыкать

landing/fragments/landing-faq/src/question-modal/question-modal.component.tsx Outdated Show resolved Hide resolved
landing/fragments/landing-library/src/card/card.component.tsx Outdated Show resolved Hide resolved
landing/fragments/landing-library/src/card/card.component.tsx Outdated Show resolved Hide resolved
landing/pages/index-page/src/index.page.tsx Outdated Show resolved Hide resolved
ui/form/src/form.interfaces.ts Outdated Show resolved Hide resolved
ui/modal/src/backdrop/backdrop.styles.ts Outdated Show resolved Hide resolved
@TorinAsakura TorinAsakura merged commit 74f4f86 into master Sep 27, 2023
6 checks passed
@TorinAsakura TorinAsakura deleted the feat/landing-fifth-step branch September 27, 2023 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oxiqod oxiqod oxiqod approved these changes

@Nelfimov Nelfimov Nelfimov approved these changes

@TorinAsakura TorinAsakura TorinAsakura approved these changes

Assignees

@Mirved64 Mirved64

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Landing - Fifth Step
4 participants
@Mirved64 @Nelfimov @TorinAsakura @oxiqod