Fix shutdown with jmx javaagent enabled

[bianchi2]

Addresses https://jira.atlassian.com/browse/SCALE-141 and #897

This PR adds jmx exporter JVM flags to CATALINA_OPTS instead of JVM_SUPPORT_RECOMMENDED_ARGS (all products except Bitbucket)

When jmx is enabled in Helm chart values, a javaagent is added to JVM_SUPPORT_RECOMMENDED_ARGS that is included JAVA_OPTS.

From catalina.sh:

   #   JAVA_OPTS       (Optional) Java runtime options used when any command
   #                   is executed.
   #                   Include here and not in CATALINA_OPTS all options, that
   #                   should be used by Tomcat and also by the stop process,
   #                   the version command etc.
   #                   Most options should go into CATALINA_OPTS.

As a result, when Tomcat is stopped, javaagent starts and since it already listens on jmx exporter port, it fails. This results in non-graceful shutdown.

From catalina.sh:

#   CATALINA_OPTS   (Optional) Java runtime options used when the "start",
#                   "run" or "debug" command is executed.
#                   Include here and not in JAVA_OPTS all options, that should
#                   only be used by Tomcat itself, not by the stop process,
#                   the version command etc.

Checklist

• I have added unit tests
• I have applied the change to all applicable products
• The E2E test has passed (use e2e label)

[farthinder]

Thanks for this!

[saldor100]

When will this be released ? its only been merged to the main

[bianchi2]

We plan the next release early next week.