Add helm value for custom jmx jar location when using other jmx init container images

[corang]

Since the first argument to the copy for the initcontainer is hardcoded, it allows only the bitnami image to be used. Making this value based allows for other images to be used instead.

[bianchi2]

@corang thanks, indeed using a different image (with a different jmx jar location) can be problematic without this fix. We'll release 1.20.2 this week.

[corang]

Do you want me to try to fix the output files for testing? @bianchi2

[bianchi2]

@corang you may run this command

docker run -v $(pwd):/app \
  -w /app maven \
  /bin/sh -c \
  "curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash &&  mvn test -B -Dtest=test.HelmOutputComparisonTest#record_helm_template_output_matches_expectations -DrecordOutput=true"

and commit changed expected output files.

[corang]

@bianchi2 If I can I would suggest adding helm dep build to the test you sent me, had to go into each chart and do it manually otherwise the tests fail

[bianchi2]

@corang ah, right. I just had the deps locally so it worked for me because of the volume mount. Thanks for fixing the tests!

[Michael-Kruggel]

Hey @bianchi2, I was looking to use this feature, but it looks like the subchart hasn't been released to reflect this change in the consuming charts. Is there an eta on this being released?

[bianchi2]

@Michael-Kruggel indeed 🤦 common was never released. We'll cut a new release this week.

UPDATE: 1.21.3 is out (bumped common dependency version to 1.2.7)