Make securityContext configurable for jmx exporter init container #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bianchi2
requested review from
nanux,
errcode1202,
yzha645,
jjeongatl,
bconroyA and
ealliaume
as code owners
1 task
nanux
approved these changes
Sep 18, 2023
src/main/charts/bamboo/values.yaml
Outdated
| jmxExporterInitContainer: | ||
|
|
||
| # -- Whether to run jmx exporter init container as root to be able to copy jmx exporter binary to shared home volume. | ||
| # Set to false if running containers as root is not allowed in the cluster |
There was a problem hiding this comment.
Suggested change
| # Set to false if running containers as root is not allowed in the cluster | |
| # Set to false if running containers as root is not allowed in the cluster. |
src/main/charts/bamboo/values.yaml
Outdated
| # | ||
| jmxExporterInitContainer: | ||
|
|
||
| # -- Whether to run jmx exporter init container as root to be able to copy jmx exporter binary to shared home volume. |
There was a problem hiding this comment.
Suggested change
| # -- Whether to run jmx exporter init container as root to be able to copy jmx exporter binary to shared home volume. | |
| # -- Whether to run JMX exporter init container as root to copy JMX exporter binary to shared home volume. |
| # | ||
| runAsRoot: true | ||
|
|
||
| # -- Custom SecurityContext for the jmx exporter init container |
There was a problem hiding this comment.
Suggested change
| # -- Custom SecurityContext for the jmx exporter init container | |
| # -- Custom SecurityContext for the JMX exporter init container |
|
thanks @nanux comments updated |
bianchi2
deleted the
configurable-security-context-jmx-init-container
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#667 is merged. This PR adds values and a few unit tests.
Checklist
e2elabel)