Add defaultMode to additionalConfigMaps

[bianchi2]

We may want to make mounted files executable, so control over defaultMode will help. Other uses cases - security requirements that may enforce certain default modes.

Checklist

• I have added unit tests
• I have applied the change to all applicable products
• The E2E test has passed (use e2e label)

[yzha645]

I find it a bit confusing to put defaultMode under each key.
mode in my opinion might be a better addition, so that we'll have spec.template.spec.volumes[n].configMap.items.mode in the statefulset.
Maybe it makes more sense to put defaultMode at configmap level? i.e.

  - name: extra-configmap
    defaultMode:
    keys:
      - fileName: hello.properties
        mountPath: /opt/atlassian/jira/atlassian-jira/WEB-INF/classes
        mode: 
        content: |
          foo=bar
          hello=world

But I have limited knowledge on how you designed additionalConfigMaps at the beginning, happy to have a chat about it.

[bianchi2]

@yzha645 thanks for your comment. I tried to use K8s terms, so, defaultMode is the volume's defaultMode. See: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#configmapvolumesource-v1-core

Also, if we move it one level up, and they have an override in each key, this will make template even more complicated - we'll have to check if defaultMode is set and then if keys[n].mode is defined. I don't see any scenarios where this type of flexibility will help.

Also, setting defaultMode is a rare case. You mostly need it if you want to make the mounted file executable.

[yzha645]

yea, thanks for the clarification. I guess in our case, each configmapvolumesource will have one and only one item, so whether set defaultMode in upper level or mode in item level probably have the same effect.