Add additional ConfigMaps to Helm Charts #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bianchi2
requested review from
nanux,
errcode1202,
yzha645,
jjeongatl and
bconroyA
as code owners
added 2 commits
August 5, 2023 10:31
bianchi2
changed the title
errcode1202
reviewed
Aug 6, 2023
src/main/charts/bamboo/values.yaml
Outdated
| @@ -1039,3 +1039,20 @@ additionalFiles: [] | |||
| # type: secret | |||
| # key: keystore.jks | |||
| # mountPath: /var/ssl | |||
|
|
|||
| # -- Create additional ConfigMaps with given names, keys and content. Helm release name will be used as prefix | |||
There was a problem hiding this comment.
Suggested change
| # -- Create additional ConfigMaps with given names, keys and content. Helm release name will be used as prefix | |
| # -- Create additional ConfigMaps with given names, keys and content. The Helm release name will be used as a prefix |
errcode1202
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the helm charts have additionalFiles which make it possible to mount external ConfigMaps to container, there are a couple of issues with this approach:
This PR adds additinalConfigMaps stanza which makes it possible to define multiple ConfigMaps with multiple keys (files) along with the content. One obvious use case is to mount log4j.properties to change logging settings. There can be other config files too.
Checklist
e2elabel)