Supported basePath for to prop when passed as string. Resolving acces…

[tpuric]

Resolves #225

Supported basePath for to prop when passed as string.
Resolves accessibility issues for new tabs/window interactions.

Test added:

• should support the to prop with basePath
• should push history with correct link given basePath

[tpuric]

yeah so this is obviously hacked in, looking for input on a better way of handling this.

Essentially the problem here is that linkDestination is used for both router actions and anchor props (href). Router actions automatically prepends basePath whilst anchor props do not, hence why we are in the current state.

This example splits the logic so they are handled separately. The approach is very naive, please provide suggestions. Alternatively, we could look at converting string typed to's to routes?

Anyways, looking for feedback, thanks.

[albertogasparin]

We already calculate the href above, don't need to recalculate everything again. We just need to understand if we need to add basepath.

const staticBasePath = href == null && typeof to === 'string' ? routeAttributes.basePath : ''
// ...
validLinkType,
  {
  ...rest,
  href: staticBasePath + linkDestination,

[tpuric]

I've applied these changes, thanks @albertogasparin