React 18 upgrade #221
React 18 upgrade #221
Conversation
| @@ -1,4 +1,5 @@ | |||
| import { render, screen } from '@testing-library/react'; | |||
| import '@testing-library/jest-dom'; | |||
There was a problem hiding this comment.
Why not importing this in the setup file? So we don't get strange errors if we move tests around
There was a problem hiding this comment.
I tried moving in my previous PR but the TS compiler starts complaining and no matter what I tried it would not satisfy the error.
There was a problem hiding this comment.
yeah, that's not ideal, I'd try to move it back to jest.setup.js
There was a problem hiding this comment.
Bigger significant changes are needed to the config, and TSConfig is required. Basing this on all the simple changes I tried.
Might be better in another PR as this one already has a lot of changes
| @@ -1,4 +1,5 @@ | |||
| import { render, screen } from '@testing-library/react'; | |||
| import '@testing-library/jest-dom'; | |||
There was a problem hiding this comment.
yeah, that's not ideal, I'd try to move it back to jest.setup.js
| @@ -272,16 +265,16 @@ describe('useQueryParam()', () => { | |||
|
|
|||
| const { storeState, actions } = getRouterStore(); | |||
|
|
|||
| actions.push('/projects/123/board/456?foo=hello&bar=world'); | |||
| await nextTick(); | |||
| act(() => { | |||
There was a problem hiding this comment.
just wondering, why are you using act here, are there any async actions under the hood of push()?
There was a problem hiding this comment.
Were not using userEvent here so we need to manually use act due to waiting for re-renders and or any other background changes.
First pass at React18 upgrade.