Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only publish jvm jar to maven. Don't need the ios ones. #47

Closed
wants to merge 1 commit into from

Conversation

nlam-atlassian
Copy link
Collaborator

Our publish action is publishing jars for ios platform too. Our artifactory directory looks like:

collab/
collab-iosarm64/
collab-iossimulatorarm64/
collab-iosx64/
collab-jvm/

and inside each directory looks something like:

collab-iossimulatorarm64-1.1.3-metadata.jar
collab-iossimulatorarm64-1.1.3-metadata.jar.asc
collab-iossimulatorarm64-1.1.3-sources.jar
collab-iossimulatorarm64-1.1.3-sources.jar.asc
collab-iossimulatorarm64-1.1.3.klib
collab-iossimulatorarm64-1.1.3.klib.asc
collab-iossimulatorarm64-1.1.3.module
collab-iossimulatorarm64-1.1.3.module.asc
collab-iossimulatorarm64-1.1.3.pom
collab-iossimulatorarm64-1.1.3.pom.asc

I don't think we need the ios verions of this, so I've changed it to only publish the jvm versions.

@tchernykh
Copy link
Collaborator

Aren't those needed to build iOS apps for Kotlin Multiplatform projects?

@nlam-atlassian
Copy link
Collaborator Author

@tchernykh I thought iOS only needed the assets in each release? in https://github.com/atlassian-labs/prosemirror-kotlin/releases/tag/1.1.3 or am I confused?

@nlam-atlassian
Copy link
Collaborator Author

Closing this PR since we want to keep all those files/directories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants