FABB-73: Add error handling for Jira getIssue 404 #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elainefigma
changed the title
There was a problem hiding this comment.
@elainefigma , while the changes looks good, please, do not merge the PR until we investigate a scenario when an HTTP 404 error occurs. Please, see more detail in the ticket.
|
@elainefigma , we have investigated the root cause of this issue. I've added more detail on our finding in Slack and created another PR with the fix: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose you do not have permissions to access a particular Jira issue. Then, the Jira getIssue request gives you a 404.
Right now, we're mapping this to 500 errors in associateEntity. However, since this is an expected case, this PR tweaks the error handling to map these to 404 errors in the endpoint.
Ticket: https://figlassian.atlassian.net/browse/FABB-73