Classify functions exposed by Rovo modules as user invocable with testing #55
+223
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution. Already signed the CLA? To re-check, try refreshing the page. |
some light clean up as well
jwong101
reviewed
Nov 25, 2024
| #[derive(Debug, Clone, PartialEq, Eq, Deserialize)] | ||
| pub struct Action<'a> { | ||
| pub key: &'a str, | ||
| pub name: &'a str, // TODO: this is not in the manifest in the example forge app, wouldn't this fail? https://bitbucket.org/atlassian/rovo-data-discoverability/src/2743f6ca42589c7d1fb2d50e0d9e65e5ef1aebbe/manifest.yml#lines-3 |
There was a problem hiding this comment.
You can just leave it off, since serde will still deserialize it correctly if an object contains more keys than what you want to deserialize into.
jwong101
reviewed
Nov 25, 2024
| pub struct Action<'a> { | ||
| pub key: &'a str, | ||
| pub name: &'a str, // TODO: this is not in the manifest in the example forge app, wouldn't this fail? https://bitbucket.org/atlassian/rovo-data-discoverability/src/2743f6ca42589c7d1fb2d50e0d9e65e5ef1aebbe/manifest.yml#lines-3 | ||
| pub function: &'a str, |
There was a problem hiding this comment.
This should probably be an Option<&'a str>, since the action can also just have an endpoint property instead of a function property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests with logic of implementation still being drafted.