-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor scheme architecture #3348
Conversation
538a5d6
to
51e6315
Compare
I have been looking at this, and haven't found any problem yet. I will continue to review it. |
|
||
(export-always 'internal-page-name) | ||
(-> internal-page-name ((or string quri:uri)) t) | ||
(defun internal-page-name (url) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is often used as a predicate, perhaps consider a -p
suffix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or at least a variant of this command that is -p
suffixed that returns t/nil.
The It even works if I set the url to home page == |
If I click on a symbol within a code block, it also does not work. I am brought again to the debugger. |
I've seen these bugs before, I'll fix those. |
51e6315
to
9c6dad0
Compare
@jmercouris should be fixed, please test it. |
Will do! |
No problems found :-) |
The handling of custom schemes is implemented in a renderer-agnostic fashion.
Mode-specific logic doesn't belong to the renderer.
9c6dad0
to
a056537
Compare
Description
A pre-requisite to #2989, in the sense that it refactors the architecture of custom schemes in a renderer-agnostic fashion. It is a follow-up to #3341.
Checklist:
(asdf:test-system :nyxt/gi-gtk)
)