Ignore PHPStan wrong array-shape subtraction warnings (#1233)

atk4 · Sep 10, 2024 · e724dc6 · e724dc6
1 parent ed9f0e6
commit e724dc6
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 2 deletions.
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -60,6 +60,33 @@ parameters:
             message: '~^Class Doctrine\\DBAL\\(Platforms\\SqlitePlatform|Schema\\SqliteSchemaManager) referenced with incorrect case: Doctrine\\DBAL\\(Platforms\\SQLitePlatform|Schema\\SQLiteSchemaManager)\.$~'
             count: 24
 
+        # remove once https://github.com/phpstan/phpstan/issues/11488 is fixed
+        -
+            path: 'src/Persistence/Sql/Oracle/Query.php'
+            identifier: nullCoalesce.variable
+            message: '~^Variable \$operator on left side of \?\? is never defined\.$~'
+            count: 1
+        -
+            path: 'src/Persistence/Sql/Oracle/Query.php'
+            identifier: instanceof.alwaysFalse
+            message: '~^Instanceof between \*NEVER\* and Atk4\\Data\\Field will always evaluate to false\.$~'
+            count: 2
+        -
+            path: 'src/Persistence/Sql/Oracle/Query.php'
+            identifier: booleanAnd.alwaysFalse
+            message: '~^Result of && is always false\.$~'
+            count: 3
+        -
+            path: 'src/Persistence/Sql/Query.php'
+            identifier: identical.alwaysFalse
+            message: '~^Strict comparison using === between \*NEVER\* and 3 will always evaluate to false\.$~'
+            count: 1
+        -
+            path: 'src/Persistence/Sql/Query.php'
+            identifier: variable.undefined
+            message: '~^(Undefined variable: \$(operator|value)|Variable \$value might not be defined\.)$~'
+            count: 3
+
         # TODO these rules are generated, this ignores should be fixed in the code
         # for src/Schema/TestCase.php
         -

diff --git a/src/Persistence/Sql/Oracle/ExpressionTrait.php b/src/Persistence/Sql/Oracle/ExpressionTrait.php
@@ -57,7 +57,7 @@ protected function escapeStringLiteral(string $value): string
     /**
      * Like mb_str_split() function, but split by length in bytes.
      *
-     * @return array<string>
+     * @return list<string>
      */
     private function splitLongString(string $value, int $lengthBytes): array
     {

diff --git a/tests/Schema/TestCaseTest.php b/tests/Schema/TestCaseTest.php
@@ -211,7 +211,7 @@ public function testLogQuery(): void
     /**
      * @param int<1, 12> $month
      *
-     * @return array<mixed>
+     * @return array<mixed, mixed>
      */
     private function createAssertSameExportUnorderedTestRow(int $month): array
     {