🐛 Fix ytmdesktop#367 migrate to electron internal Notifiations API

atcq · Sep 13, 2020 · 5fad6bf · 5fad6bf
1 parent e4c5e30
commit 5fad6bf
Show file tree

Hide file tree

Showing 3 changed files with 75 additions and 11 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -44,7 +44,6 @@
         "electron-is-dev": "^1.2.0",
         "electron-localshortcut": "^3.2.1",
         "electron-log": "^4.2.2",
-        "electron-native-notification": "^1.2.1",
         "electron-store": "^6.0.0",
         "electron-updater": "^4.3.4",
         "i18n": "^0.10.0",

diff --git a/src/providers/trayProvider.js b/src/providers/trayProvider.js
@@ -8,6 +8,7 @@ const systemInfo = require('../utils/systemInfo')
 const imageToBase64 = require('image-to-base64')
 const { popUpMenu } = require('./templateProvider')
 const assetsProvider = require('./assetsProvider')
+const { Notification } = require('electron')
 
 let tray = null
 let saved_mainWindow = null
@@ -154,13 +155,14 @@ function _doNotification(title, content, icon) {
                     }, 7 * 1000)
                 }
             } else {
-                let Notification = require('electron-native-notification')
-
-                new Notification(title, {
+                // create a system notification and send it
+                let myNotification = new Notification({
+                    title: title,
                     body: content,
                     silent: true,
                     icon: icon,
-                })
+                    urgency: 'low',
+                }).show()
             }
         }
     } catch (error) {