Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for Workflow connectors #275

Merged
merged 2 commits into from
Jul 25, 2024

Commits on Jul 24, 2024

  1. Add initial support for Workflow connectors

    - lower `AdaptiveCardMaxVersion` from `1.5` to `1.4`
      - this almost seems like a bug on Teams' end as this limitation is
        not communicated (from what I could tell) via
        https://adaptivecards.io/designer/
      - using a value of `1.4` appears to work equally well for O365 and
        Workflow connectors
    - treat a 202 response code as sufficient response verification
      - instead of expecting a `1` in the response body as previously
        confirmed
      - see also #59
    - add `logic.azure.com` to valid URL patterns for default validation
    - debugging / troubleshooting
        - log status code and response string for O365 connector responses
        - log validation pattern match
    
    refs GH-262
    atc0005 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    245024b View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Refactor regex for default Workflow URLs

    Switch from static base pattern of `logic.azure.com` to a regex
    OR pattern to permit either of `logic.azure.com` or
    `*.azure-api.net` as has been observed in the wild.
    
    This also has the side effect of resolving potential CodeQL
    alerts raised in PR GH-275.
    
    refs GH-262
    atc0005 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    7cdd311 View commit details
    Browse the repository at this point in the history