Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: new accessibility page #1418
docs: new accessibility page #1418
Changes from 24 commits
a4fcd17
b4d3cf5
d0f37c0
732ddbf
81a49eb
2df18ce
bdcac3b
91ca2f4
326c4fc
cd125fd
0a51abf
bc37b86
8a82cc3
7532223
9ce02cf
1ef949a
1ed0b19
6597852
186a20a
355bf7b
8544de7
49a3ddd
fac245f
746aa12
829d87d
3abe479
c0ac0c6
27a07b7
03fd821
137cacc
ea44d39
6435902
69d8be6
3389cf6
fb3a3de
3ca0a22
a36255d
281a63c
b78ad0b
5bd2aeb
fd47734
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your "Accessibility" Style Guide document provides a solid basis for creating inclusive and accessible content! Nice work, per usual, @thulieblack! Here are a few suggestions to enhance clarity and usefulness.
Language
Text
Links
Multimedia
User Interface
Color usage (missing)
Please add a section on accessible color usage, especially for contributors who might be creating diagrams or other visual content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more content on the missing sections. How is it now? @alequetzalli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there! just a few fixes left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See..what? To make it descriptive, link text must describe where the link takes them.
Please write a new example 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣🤣 you are schooling me on accessibility, and I'm glad I'm learning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should we use an external link icon if a link opens up in a new tab? Source and reasoning? Want to make sure this is advice we actually believe 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory agreed... but is this actually something we practice in our docs? So far, I have not seen us use SVGs on our website (or docs). I would remove this line if it is incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basic
HTML? 😄 Why is a button HTML elementbasic
? This word choice is wrong because it conveys an assumption and judgement on poor HTML 😂✌🏽