Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: security schemas by upgrading the dependency #1086

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

RobinTail
Copy link
Contributor

@RobinTail RobinTail commented Apr 25, 2024

Description

Related issue(s)

Fixes #1066

Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: be9a235

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/studio Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for studio-next ready!

Name Link
🔨 Latest commit be9a235
🔍 Latest deploy log https://app.netlify.com/sites/studio-next/deploys/662a2c85f3e6e800084b9265
😎 Deploy Preview https://deploy-preview-1086--studio-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit be9a235
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/662a2c8576d0c50008bd97d4
😎 Deploy Preview https://deploy-preview-1086--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit be9a235
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/662a2c85193b5c00082b9a10
😎 Deploy Preview https://deploy-preview-1086--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RobinTail RobinTail changed the title Upgrading @asyncapi/react-component to 1.4.10. fix: security references by upgrading the fixed dependency Apr 25, 2024
@RobinTail RobinTail force-pushed the issue-1066-security-refs branch from d1af2dd to 6b86367 Compare April 25, 2024 10:07
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@RobinTail RobinTail marked this pull request as ready for review April 25, 2024 10:13
@RobinTail RobinTail changed the title fix: security references by upgrading the fixed dependency fix: security schemas by upgrading the fixed dependency Apr 25, 2024
@RobinTail RobinTail changed the title fix: security schemas by upgrading the fixed dependency fix: security schemas by upgrading the dependency Apr 25, 2024
@RobinTail
Copy link
Contributor Author

@Amzani , please review.
Did my best to align it with the contribution guidelines.
Let me know if I missed something.

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KhudaDad414
Copy link
Member

/rtm

@KhudaDad414
Copy link
Member

Thanks for the contribution @RobinTail 🙇

@asyncapi-bot asyncapi-bot merged commit 481b28c into asyncapi:master Apr 26, 2024
40 checks passed
KhudaDad414 pushed a commit to KhudaDad414/studio that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Incorrect rendering of security schemas: by reference and inline
3 participants