Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: makes glee internal features into pages #522

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

afzal442
Copy link
Contributor

Description
This PR recreates glee internal features into pages

Related issue(s)

Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these docs go under the pages folder just like the installation doc also is the pages folder for rending on the website?

@afzal442
Copy link
Contributor Author

afzal442 commented Oct 6, 2023

Hey @Souvikns sorry for the delay

Should these docs go under the pages folder ...

I think let's first render the existing pages like installation guide and see how it looks

is the pages folder for rending on the website?

Yes using github action as described here #481

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6495326389

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.392%

Totals Coverage Status
Change from base Build 6469934494: 0.0%
Covered Lines: 360
Relevant Lines: 470

💛 - Coveralls

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@KhudaDad414
Copy link
Member

Let's wait for @Souvikns review.

@afzal442
Copy link
Contributor Author

pinging @Souvikns 😃

@afzal442
Copy link
Contributor Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 41c5f6c into asyncapi:master Nov 21, 2023
12 checks passed
@afzal442 afzal442 deleted the create-glee-feats branch November 21, 2023 03:36
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants