-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hyperopt example for BERT classifier #186
Conversation
fb9e563
to
1fc8aea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So now the OOM issue is fixed?
Yes, the issue was caused because |
Looks good on my side. Do we still have a plan of adding relevant Executor hyper tuning modules? |
I discussed with @huzecong on keras-tuner like interfaces for Executor. They do not provide any additional functionalities but may provide some good utilities for the user. I think this is good and we can add these features in the future if we get requests from the users. |
fa829b6
to
61dc094
Compare
Let's make an issue to keep track of this |
|
This PR
Adds an example to showcase hyperparameter tuning with Executor
Fixes a memory leakage issue in Executor due to
atexit
(Now, opening and closing of files are done explicitly intrain
andtest
methods)