Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for gwcs inverse transform with a bounding_box #1204

Closed
wants to merge 1 commit into from
Closed

Fix for gwcs inverse transform with a bounding_box #1204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ install_requires =
numpy>=1.24
scipy>=1.3
astropy>=5.1
gwcs>=0.18
gwcs @ git+https://github.com/nden/gwcs.git@inverse-bbox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a PR on gwcs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I was asking about above as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I think it is spacetelescope/gwcs#498 that is already merged

asdf-astropy>=0.3
asdf>=2.14.4
ndcube>=2.0
Expand Down
2 changes: 1 addition & 1 deletion specutils/tests/test_spectrum1d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ def test_wcs_transformations():
with u.set_enabled_equivalencies(u.spectral()):
# After spacetelescope/gwcs#457 is merged and released, this can be changed to
# spec.wcs.world_to_pixel_values(np.arange(20, 30) * u.GHz)
spec.wcs.world_to_pixel(SpectralCoord(np.arange(20, 30) * u.GHz))
spec.wcs.world_to_pixel(SpectralCoord(np.arange(6.9e6, 1e7) * u.GHz))

# Test with a FITS WCS
my_wcs = fitswcs.WCS(header={'CDELT1': 1, 'CRVAL1': 6562.8, 'CUNIT1': 'Angstrom',
Expand Down
Loading