Reverts PR 1193 (Ignore GwcsBoundingBoxWarning in JWST readers) #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1194 +/- ##
==========================================
- Coverage 86.92% 86.90% -0.02%
==========================================
Files 63 63
Lines 4572 4576 +4
==========================================
+ Hits 3974 3977 +3
- Misses 598 599 +1 ☔ View full report in Codecov by Sentry. |
pllim
force-pushed
the
revert-ignore-gwcs-bb-warn
branch
from
8605f01 to
d0c667d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
pllim
force-pushed
the
revert-ignore-gwcs-bb-warn
branch
from
d0c667d to
734feaa
Compare
This reverts commit 170d70f.
pllim
force-pushed
the
revert-ignore-gwcs-bb-warn
branch
from
734feaa to
a2527c0
Compare
pllim
changed the title
|
devdeps failure unrelated |
rosteen
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1193 and use spacetelescope/gwcs#526 instead.
Blocked by: