-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of line matching #182
Merged
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
c7c11d5
rename and move function to return available line catalogs.
tepickering eb002d4
tweak docstring; add initial sketch for LineMatch classes
tepickering 9130a1b
dev notebook work; more line_matching sketch-up
tepickering 2f3714d
add ruff config to pyproject for faster linting
tepickering d035f85
remove check for astropy < 3.x
tepickering 7f7e350
add missing function to __all__ in synth_data.py
tepickering dc641db
Merge remote-tracking branch 'upstream/main' into line_matching
tepickering a63aa45
make the spatial profile for a traced source a passed argument vs har…
tepickering aad31d4
codestyle cleanups
tepickering 026a600
flesh out type annotations in synth_data and edit docstrings to refle…
tepickering 608e111
notebook edits
tepickering 3ad3b4f
comment out undefined method for now
tepickering 60b624c
change relative to absolute imports
tepickering 6f1a7aa
remove astropy_helpers vestige; packaging cleanups; set python_requir…
tepickering f6e50d0
update tox.ini to reflect new python_requires
tepickering 4f4d660
update CI workflows
tepickering 96c52ad
flesh out more type annotations
tepickering cd9717d
add support for comma-separated strings to build line catalogs
tepickering ef57d34
update dev notebook to reflect some api changes in linelists
tepickering be406a7
flesh out match_lines_wcs; save notebook dev
tepickering d61cd63
actually commit dev notebook
tepickering 6b4f9f6
loosen typing on match_lines_wcs, but add sanity checking by casting …
tepickering 9d27c7e
add routine to find arc lines and centroid them
tepickering 8eeb8e0
fix units in match_lines_wcs
tepickering f68267e
allow fwhm to be a float and assume u.pix if so
tepickering 79e31ea
fix line matching tests to ignore warnings and mark use of remote data
tepickering 6b6f75a
add wavecal_demo notebook
tepickering 7f7a192
Merge remote-tracking branch 'upstream/main' into line_matching
tepickering c098278
fix some post-merge issues
tepickering 4bd0652
fix column name to match
tepickering 1e4577c
demo notebook updates; codestyle fixes
tepickering 10ef0a1
remove old numpy versions from tox.ini that aren't python 3.10 compat…
tepickering 3a1d1ac
tweak up min tested scipy version
tepickering 298a4fe
ignore new datetime warnings in python 3.12
tepickering 553d6f2
Merge branch 'main' into line_matching
tepickering 8c8123d
remove crutches for py312; don't seem to be needed anymore
tepickering e310f07
fix typo; clarify docstring; simplify check
tepickering 1436ce0
resolve the myriad conflicts encountered when merging #202
tepickering c6a8bc8
codestyle fix
tepickering 8994bb9
code now is using features that require python >= 3.10
tepickering f226188
add warning to line_matching.py if the matched set is empty
tepickering 1ed3c2c
fix codestyle bug; remove mark from fixture in test_line_matching
tepickering 1845c6f
fix name in workflow
tepickering File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
# Licensed under a 3-clause BSD style license - see LICENSE.rst | ||
|
||
# Packages may add whatever they like to this file, but | ||
# should keep this content at the top. | ||
# ---------------------------------------------------------------------------- | ||
from ._astropy_init import * # noqa | ||
# ---------------------------------------------------------------------------- | ||
|
||
from specreduce.core import * # noqa | ||
from specreduce.wavelength_calibration import * # noqa | ||
|
||
|
||
try: | ||
from .version import version as __version__ | ||
except ImportError: | ||
__version__ = '' | ||
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this necessary? specreduce.__version__ seems to be correct already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it may not be. i just moved it over from
_astropy_init.py
as-is so there'd be no surprises. kind of a vestige of the oldastropy-helpers
, but other coordinated packages likephotutils
have this in their__init__.py
as well, fwiw.