SodaRecordMixin no longer will use a datalink#links endpoint for soda #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oda. It is unclear why it ever did this, as I really do not see how this would ever have a beneficial effect (the only parameter understood by both links and SODA is ID, and even that is interpreted in totally different ways). It has, however, a detrimental effect; see bug astropy#578.
msdemlei
force-pushed
the
no-longer-use-links-for-soda
branch
from
4a04a13 to
1ce9ea2
Compare
|
From what I've searched, I can only imagine that the intend might have been to try other |
andamian
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unclear why it ever did this, as I really do not see how this would ever have a beneficial effect (the only parameter understood by both links and SODA is ID, and even that is interpreted in totally different ways). It has, however, a detrimental effect; see bug #578.
Fixes #578